-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parallels child detection #855
Add Parallels child detection #855
Conversation
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 76.30% 76.33% +0.03%
==========================================
Files 312 313 +1
Lines 26823 26859 +36
==========================================
+ Hits 20467 20503 +36
Misses 6356 6356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you fix the linter in tests/plugins/child/test_parallels.py
this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the test fails on Windows?
That's strange. I can't think of any reason why that would fail. I've tried something, could you run the tests again? I am unable to test on Windows currently. |
That does not seem to have fixed it unfortunately. Could you take a look @Schamper? |
I'm going on vacation and unfortunately don't have time to look at this now, I'll see if someone from the team can help 😄 |
This PR adds Parallels child detection for MacOS targets.