Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parallels child detection #855

Merged

Conversation

JSCU-CNI
Copy link
Contributor

This PR adds Parallels child detection for MacOS targets.

@Schamper Schamper changed the title Add parallels child detection Add Parallels child detection Sep 19, 2024
dissect/target/plugins/child/parallels.py Outdated Show resolved Hide resolved
dissect/target/plugins/child/parallels.py Outdated Show resolved Hide resolved
dissect/target/plugins/child/parallels.py Show resolved Hide resolved
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.33%. Comparing base (a395d13) to head (cb77d34).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
+ Coverage   76.30%   76.33%   +0.03%     
==========================================
  Files         312      313       +1     
  Lines       26823    26859      +36     
==========================================
+ Hits        20467    20503      +36     
  Misses       6356     6356              
Flag Coverage Δ
unittests 76.33% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you fix the linter in tests/plugins/child/test_parallels.py this is good to go.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test fails on Windows?

@JSCU-CNI
Copy link
Contributor Author

That's strange. I can't think of any reason why that would fail. I've tried something, could you run the tests again? I am unable to test on Windows currently.

@JSCU-CNI
Copy link
Contributor Author

That does not seem to have fixed it unfortunately. Could you take a look @Schamper?

@Schamper
Copy link
Member

I'm going on vacation and unfortunately don't have time to look at this now, I'll see if someone from the team can help 😄

@EinatFox EinatFox linked an issue Sep 26, 2024 that may be closed by this pull request
@twiggler
Copy link
Contributor

twiggler commented Sep 27, 2024

That does not seem to have fixed it unfortunately. Could you take a look @Schamper?

@JSCU-CNI I have identified the problem and am devising a fix.

@twiggler
Copy link
Contributor

twiggler commented Sep 27, 2024

@JSCU-CNI I have created a fix for the root cause in a separate PR: #867

After the fix has been merged, you can rebase so that your unit test should pass when running on windows.

@JSCU-CNI
Copy link
Contributor Author

@JSCU-CNI I have created a fix for the root cause in a separate PR: #867

Thanks for investigating the issue, I have left some comments on your proposed fix.

@twiggler
Copy link
Contributor

twiggler commented Oct 3, 2024

@JSCU-CNI #867 has been merged, you can rebase

@Schamper Schamper merged commit 3ac5b79 into fox-it:main Oct 7, 2024
18 checks passed
@JSCU-CNI JSCU-CNI deleted the feature/add-parallels-desktop-child-detection branch October 7, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Parallels child detection
3 participants